Hello Kyösti Mälkki, HAOUAS Elyes, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32022
to look at the new patch set (#5).
Change subject: nb/amd/pi, mb/amd/bettong: Fix null pointer checks ......................................................................
nb/amd/pi, mb/amd/bettong: Fix null pointer checks
The dev pointers were being dereferenced before the null check. Move the checks so they are done earlier.
Found-by: Coverity Scan, CID 1241851 (REVERSE_INULL) Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Ie578787c3c26a1f3acb4567c135486667e88a888 --- M src/mainboard/amd/bettong/BiosCallOuts.c M src/northbridge/amd/pi/00630F01/dimmSpd.c M src/northbridge/amd/pi/00660F01/dimmSpd.c M src/northbridge/amd/pi/00730F01/dimmSpd.c 4 files changed, 24 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/32022/5