Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26859 )
Change subject: cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/#/c/26859/48/src/cpu/intel/car/non-evict/cache_a...
File src/cpu/intel/car/non-evict/cache_as_ram.S:
https://review.coreboot.org/#/c/26859/48/src/cpu/intel/car/non-evict/cache_a...
PS48, Line 36: #if IS_ENABLED(CONFIG_C_ENVIRONMENT_BOOTBLOCK)
haswell, broadwell and all users of soc/intel/common/block/cpu/car/cache_as_ram.S are doing this. […]
Previous platforms might be doing the same thing using SSKPD register set to 0xCAFE.
Mostly I just did not want to see this part hidden in a cpu/haswell commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/26859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea
Gerrit-Change-Number: 26859
Gerrit-PatchSet: 48
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Sun, 14 Apr 2019 16:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment