Attention is currently required from: Philipp Hug, Julius Werner, ron minnich, HAOUAS Elyes.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50167 )
Change subject: include/cbfs.h: Add comment for chain-includes of commonlib
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I've drafted an addition to the coding style as CB:50247 (it currently doesn't say anything about in […]
Thank you, a fine start there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98fb5df0148a3f5fe0bc5b08c5a0b8b1e95c4624
Gerrit-Change-Number: 50167
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 03 Feb 2021 07:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment