Alicja Michalska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email )
Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig ......................................................................
device/Kconfig: Make option to allocate above 4G appear in Kconfig
Previously only tested on server platforms - it wasn't working correctly on consumer platforms due to missing boolean.
This patch fixes it, which makes resource allocator use uint64 instead of uint32. Thanks to that, modern GPUs like Intel Arc or Radeon RX now work correctly with ReBAR enabled, and correctly initialize the framebuffer in payload (i.e EDK2) after initializing the OpROMs.
Example of issue caused by resource allocator using uint32 (Intel Arc A580): [ERROR] Resource didn't fit!!! [ERROR] PCI: 00:01:00.0 10 prefmem64 size: 0x0000800000 not assigned [ERROR] PCI: 00:03:00.0 18 prefmem64 size: 0x0200000000 not assigned
(Followed by Linux reporting that BAR space was limited to 256MB, which severly hindered the performance).
TESTed on Intel TigerLake-H (mb/erying/tgl) with Intel Arc A580 and AMD Radeon RX7800XT.
Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Signed-off-by: Alicja Michalska alicja.michalska@9elements.com --- M src/device/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/86131/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index bcff6fd..2f5f434 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -1010,11 +1010,12 @@ problems on some platforms, at least with Intel's IGD.
config ALWAYS_ALLOW_ABOVE_4G_ALLOCATION - bool + bool "Extend resource window for PCIe devices" default n if ARCH_X86 default y help Don't limit mem resources to 4G, but to their actual limit. + This is required for modern graphics cards, i.e. Intel Arc.
config XHCI_UTILS def_bool n