Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38491 )
Change subject: mainboard/hatch: Fix GPE wake comments ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38491/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/38491/2/src/mainboard/google/hatch/... PS2, Line 59: confusingly, as : * GPE_LAN_WAK
Why do you say confusingly? EC_PCH_WAKE_ODL is routed to GPD2/LAN_WAKE# on the PCH as you said. […]
I know. I mean it is confusing if someone who didn't write/read the schematic that some pin is called "LAN_SOMETHING" however doesn't go to the lan. This is just meant to delineate the names a little ;)