Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
I don't understand using HATCH as a model, when the boards listed in Kconfig. […]
IMHO, this already looks quite messy already: https://github.com/coreboot/coreboot/blob/master/src/mainboard/intel/coffeel...
But guess what? We can actually try something that would make everyone happy enough:
Kconfig.name:
config BOARD_FOO_CFL_H bool "Foo Coffee Lake H board" select BOARD_FOO_CFL_SERIES_BASEBOARD
config BOARD_FOO_CFL_S bool "Foo Coffee Lake S board" select BOARD_FOO_CFL_SERIES_BASEBOARD
config BOARD_FOO_CFL_U bool "Foo Coffee Lake U board" select BOARD_FOO_CFL_SERIES_BASEBOARD
config BOARD_FOO_WHL_U bool "Foo Whiskey Lake U board" select BOARD_FOO_CFL_SERIES_BASEBOARD
config BOARD_FOO_CML_S bool "Foo Comet Lake S board" select BOARD_FOO_CFL_SERIES_BASEBOARD
config BOARD_FOO_CML_U bool "Foo Comet Lake U board" select BOARD_FOO_CFL_SERIES_BASEBOARD
Kconfig: config BOARD_FOO_CFL_SERIES_BASEBOARD def_bool n select HAVE_ACPI_RESUME ...
if BOARD_FOO_CFL_SERIES_BASEBOARD
config BOARD_FOO_CFL_H select BOARD_ROMSIZE_KB_16384 select SOC_INTEL_COFFEELAKE select SOC_INTEL_CANNONLAKE_PCH_H
config BOARD_FOO_CFL_S select BOARD_ROMSIZE_KB_32768 select SOC_INTEL_COFFEELAKE select SOC_INTEL_CANNONLAKE_PCH_H
config BOARD_FOO_CFL_U select BOARD_ROMSIZE_KB_32768 select SOC_INTEL_COFFEELAKE
config BOARD_FOO_WHL_U select BOARD_ROMSIZE_KB_16384 select SOC_INTEL_WHISKEYLAKE
config BOARD_FOO_CML_U select BOARD_ROMSIZE_KB_32768 select SOC_INTEL_COMETLAKE_1