Attention is currently required from: Paul Menzel, Rocky Phagura, Arthur Heymans, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54343 )
Change subject: cpu/x86/smm: Fix u32 type mismatch in print statement
......................................................................
Patch Set 4:
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/54343/comment/9f475a54_14e9550f
PS4, Line 414: %" PRIx32 "
The type is u32 as seen in the pasted build error in the commit message. […]
Then...
const size_t stack_end = stub_params->stack_top -
(params->num_concurrent_stacks * params->per_cpu_stack_size);
printk(BIOS_DEBUG, "%s: stack_end = 0x%zx\n", __func__, stack_end);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib504bc5e5b19f62d4702b7f485522a2ee3d26685
Gerrit-Change-Number: 54343
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 27 May 2021 11:16:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment