Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers. ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/... PS5, Line 61: SOC_INTEL_COMMON_MMC_OVERRIDE
Actually, I wanted to see if we can avoid configuring the UPDs completely for eMMC? If coreboot can […]
Hi Furquan, I would still suggest to use UPD for long term. So far this override mechanism is just for short term WA for kindred before newer FSP is landed thanks.
https://review.coreboot.org/c/coreboot/+/35040/8/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/8/src/soc/intel/common/block/... PS8, Line 67: if (override) { : printk(BIOS_INFO, "Skip Emmc dll value programming\n"); : return -1; : } :
Why is this required? Return value is anyways not used.
Hi Furquan, set_mmc_dll is also being used by early_mmc.c. It will check the return value. thanks