HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: soc/intel: Add Intel Xeon Scalable Processor support ......................................................................
Patch Set 37:
(6 comments)
thx
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/boot... File src/soc/intel/xeon_sp/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/boot... PS37, Line 18: #include <cpu/x86/mtrr.h> seems to be not used
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/boot... PS37, Line 25: include <timestamp.h> not used ? please check the other includes
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/chip... File src/soc/intel/xeon_sp/chip.h:
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/chip... PS37, Line 23: #include <commonlib/helpers.h> : #include <intelblocks/cfg.h> : #include <intelblocks/gspi.h> : #include <soc/gpe.h> : #include <soc/irq.h> : #include <soc/pci_devs.h> maybe some are not used
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/incl... File src/soc/intel/xeon_sp/include/soc/nvs.h:
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/incl... PS37, Line 24: uint16_t needs <stdint.h>
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/incl... File src/soc/intel/xeon_sp/include/soc/pm.h:
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/incl... PS37, Line 21: #include <arch/acpi.h> : #include <device/mmio.h> : #include <soc/gpe.h> : #include <soc/iomap.h> : #include <soc/pmc.h> please check
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/smih... File src/soc/intel/xeon_sp/smihandler.c:
https://review.coreboot.org/c/coreboot/+/38548/37/src/soc/intel/xeon_sp/smih... PS37, Line 18: #include <arch/hlt.h> not used ?