Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75133 )
Change subject: Kconfig: Get rid of named choice LAPCIC_ACCESS_MODE ......................................................................
Kconfig: Get rid of named choice LAPCIC_ACCESS_MODE
The named choice isn't needed here, so get rid of it. This fixes the build notice:
build/auto.conf:notice: override:reassigning to symbol LAPIC_ACCESS_MODE
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I70628007319a0ee2830dc4c9cb3b635d8190264b --- M src/cpu/x86/Kconfig 1 file changed, 19 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/75133/1
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index c85eace..1e1b2ac 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -28,19 +28,19 @@ config DEFAULT_X2APIC def_bool n help - Allow SoC code to set LAPIC_ACCESS_MODE to X2APIC. + Allow SoC code to set LAPIC access mode to X2APIC.
config DEFAULT_X2APIC_RUNTIME def_bool n help - Allow SoC code to set LAPIC_ACCESS_MODE to X2APIC_RUNTIME. + Allow SoC code to set LAPIC access mode to X2APIC_RUNTIME.
config DEFAULT_X2APIC_LATE_WORKAROUND def_bool n help - Allow SoC code to set LAPIC_ACCESS_MODE to X2APIC_LATE_WORKAROUND. + Allow SoC code to set LAPIC access mode to X2APIC_LATE_WORKAROUND.
-choice LAPIC_ACCESS_MODE +choice prompt "APIC operation mode" default X2APIC_ONLY if DEFAULT_X2APIC default X2APIC_RUNTIME if DEFAULT_X2APIC_RUNTIME