[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/common/block/gpio: Add gpio_pm_configure() function

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32788 )

Change subject: soc/intel/common/block/gpio: Add gpio_pm_configure() function
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/32788/5/src/soc/intel/common/block/gpio/gpio... 
File src/soc/intel/common/block/gpio/gpio.c:

https://review.coreboot.org/#/c/32788/5/src/soc/intel/common/block/gpio/gpio... 
PS5, Line 73: 	/* no-op */
> no-op means `mask` and `value` stay unitialized and registers are filled with […]

Done

https://review.coreboot.org/#/c/32788/5/src/soc/intel/common/block/gpio/gpio... 
PS5, Line 633: 	soc_fill_gpio_pm_configuration(misccfg_pm_mask, misccfg_pm_value);
> I don't understand why you want to call back to soc code. As Furquan […]

Done