Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... PS2, Line 86: ACPI_GPIO_INPUT_ACTIVE_LOW
Hm, I see, that's odd.
I think what you care about is reading the state of the signal when IRQ is triggered. And the driver wants to know the polarity because the signal could be active high or active low in hardware.
Wouldn't it make sense to apply the inversion at the pad and then use GpioInt() with both-edge trigger here? That will ensure - Signal is inverted at the pad rx and interrupt is triggered for both edges. And when the driver reads the state of the signal, it will always have to check for 1 instead of caring for the polarity.