Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Remove direct 'include <soc/gpio.h>'
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34233/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34233/5//COMMIT_MSG@10
PS5, Line 10: include <gpio.h>.
: <gpio.h> is supposed to provide indirect include <soc/gpio.h>.
I would suggest rephrasing this part, emphasizing that <soc/gpio.h> is SoC-specific.
include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb
Gerrit-Change-Number: 34233
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wvervoorn
wvervoorn@eltan.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 18:36:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment