14 Dec
2019
14 Dec
'19
6:10 p.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37727 )
Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m/... PS4, Line 19: include <console/console.h> remove? would you check the others includes
https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m/... PS4, Line 32: define MMIO_NON_POSTED_START 0xfed00000 : #define MMIO_NON_POSTED_END 0xfedfffff remove ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885
Gerrit-Change-Number: 37727
Gerrit-PatchSet: 5
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 14 Dec 2019 18:10:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment