Attention is currently required from: Subrata Banik, Paul Menzel, Sridhar Siricilla, Kane Chen.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63169 )
Change subject: soc/intel/common: Update CSE sub partition update
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/63169/comment/6a95cad6_8ff1a322
PS2, Line 786: uint32_t size;
: uint32_t start_offset;
: uint32_t end_offset;
Gentle ping.
cse_get_bp_entry_range takes uint32_t* as parameters
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/63169/comment/bdb2d505_43bb7206
PS5, Line 955: static const char * const cse_regions[] = {"RO", "RW"};
Since you are also reusing this ("RO" anyway) on line 793, does it make sense to move this declaration to file scope ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63169
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9a83b77ab44ea6ffe5bb20673e109a89a148629
Gerrit-Change-Number: 63169
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Mon, 04 Apr 2022 16:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment