Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39669 )
Change subject: mb/intel/jasperlake_rvp: Add camera support Jasper Lake RVP
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39669/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39669/15//COMMIT_MSG@9
PS15, Line 9: 1. Add support as per the schematics
: 2. Add 2 Ports and 2 Endpoints
nit: Add some more information here, like below […]
Updated
https://review.coreboot.org/c/coreboot/+/39669/15//COMMIT_MSG@11
PS15, Line 11: OTVI5676
OVTI5675?
Updated.
https://review.coreboot.org/c/coreboot/+/39669/15/src/mainboard/intel/jasper...
File src/mainboard/intel/jasperlake_rvp/variants/baseboard/include/baseboard/acpi/cam0.asl:
https://review.coreboot.org/c/coreboot/+/39669/15/src/mainboard/intel/jasper...
PS15, Line 49: Device (CAM0)
The same sensor in CAM1 has a VCM device? shouldn't this one also contain an entry for VCM?
Updated the correct sensor details
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07ae9e3473c16bde8eb1597460e70cc478357b98
Gerrit-Change-Number: 39669
Gerrit-PatchSet: 16
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sooraj Govindan
sooraj.govindan@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 May 2020 14:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment