Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph. Hello build bot (Jenkins), Furquan Shaikh, Nick Vaccaro, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52765
to look at the new patch set (#2).
Change subject: device: Switch pci_dev_is_wake_source to take pci_devfn_t ......................................................................
device: Switch pci_dev_is_wake_source to take pci_devfn_t
With the recent switch to SMM module loader v2, the size of the SMM for module google/volteer increased to above 64K in size, and thus failed to install the permanent SMM handler. Turns out, the devicetree is all pulled into the SMM build because of elog, which calls `pci_dev_is_wake_source`, and is the only user of `struct device` in SMM. Changing this function to take a pci_devfn_t instead allows the linker to remove almost the entire devicetree from SMM (only usage left is when disabling HECI via SMM).
BUG=b:186661594 TEST=Verify loaded program size of `smm.elf` for google/volteer is almost ~50% smaller.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I4c39e5188321c8711d6479b15065e5aaedad8f38 --- M src/device/pci_ops.c M src/drivers/wifi/generic/generic.c M src/include/device/pci_ops.h M src/soc/intel/alderlake/elog.c M src/soc/intel/jasperlake/elog.c M src/soc/intel/tigerlake/elog.c 6 files changed, 25 insertions(+), 59 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/52765/2