Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48206 )
Change subject: mb/google/puff/var/dooly: Update DPTF parameters
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48206/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/dooly/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48206/1/src/mainboard/google/hatch/...
PS1, Line 209: 40000
Keep both PL2 Max and Min value same as 49W.
I see other puff series set PL2 15/51 or 25/64.
May I know why this suggestion?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c4bae181e87f87f2e92337bb9d989f5b7d955
Gerrit-Change-Number: 48206
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Dec 2020 09:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment