Attention is currently required from: Andy Pont, Paul Menzel.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60165 )
Change subject: ec/starlabs/merlin: Apply EC settings when suspending
......................................................................
Patch Set 13:
(1 comment)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/60165/comment/37afe5e5_19a096a0
PS12, Line 10: _SB.PCI0.LPCB.TPLC = _SB.PCI0.LPCB.EC.TPLE
Can you please elaborate in the commit message, why the assignment was switched? So before, the valu […]
Done, and yes they were.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I998d5509cd5e95736468f88663a1423217cf6ddf
Gerrit-Change-Number: 60165
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 03 Jan 2022 17:11:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment