8 Apr
2020
8 Apr
'20
3:55 p.m.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40271 )
Change subject: sb/intel: Factor out early_smbus.c for ICH7 and newer ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40271/2/src/southbridge/intel/commo... File src/southbridge/intel/common/early_smbus.h:
https://review.coreboot.org/c/coreboot/+/40271/2/src/southbridge/intel/commo... PS2, Line 7: #define PCI_DEV_SMBUS PCI_DEV(0x0, 0x1f, 0x3) Use PCH_DEV_SLOT_LPC here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id16929cb9c25b8ec3bd067bf7d7605bce1fad2c5
Gerrit-Change-Number: 40271
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Christian Walter christian.walter@9elements.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Apr 2020 15:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment