Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85357?usp=email )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/amd/common/psp/psp_def.h: increase P2C_BUFFER_MAXSIZE ......................................................................
soc/amd/common/psp/psp_def.h: increase P2C_BUFFER_MAXSIZE
This matches the size used in the reference code and required by the corresponding document #55758 Rev. 2.04. This doesn't seem to make any difference in runtime behavior, but I'd rather waste a kilobyte of SMM RAM, than debugging possible problems caused from not following the corresponding specification.
Change-Id: I2ee30d6d1255317efcd3960016069dfe50885aa7 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/85357 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/psp/psp_def.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index d11199d..369ef08 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -133,7 +133,7 @@ #define PSP_CMD_TIMEOUT 1000 /* 1 second */
#define C2P_BUFFER_MAXSIZE 0xc00 /* Core-to-PSP buffer */ -#define P2C_BUFFER_MAXSIZE 0xc00 /* PSP-to-core buffer */ +#define P2C_BUFFER_MAXSIZE 0x1000 /* PSP-to-core buffer */
/* PSP to x86 status */ enum mbox_p2c_status {