Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30800 )
Change subject: southbridge/intel/common/smbus.c: Add support for I2C commands ......................................................................
Patch Set 3:
(2 comments)
Patch Set 3:
Ok. I just wanted to be sure about the command format the slave side expects to see.
Unless you really want to, you don't need to rebase your changes. I think it's more valuable if you are available for testing the new code I push.
The trouble here is the lack of symmetry on i2c_block_read() and i2c_block_write(), as they use different command code fields on the host controller.
https://review.coreboot.org/#/c/30800/3/src/southbridge/intel/common/smbus.c File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/#/c/30800/3/src/southbridge/intel/common/smbus.c... PS3, Line 482: outb(cmd, smbus_base + SMBHSTDAT1);
When the controller is placed into I2C mode the output stream differs from SMBus. […]
Done
https://review.coreboot.org/#/c/30800/3/src/southbridge/intel/common/smbus.c... PS3, Line 485: outb(bytes, smbus_base + SMBHSTDAT0);
The block length is not send to the slave address, but used for the SMBus controller only. […]
Done