Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36990 )
Change subject: soc/mediatek/mt8183: Tx delay cell should use ddr clock do compute
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36990/2/src/soc/mediatek/mt8183/dra...
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/36990/2/src/soc/mediatek/mt8183/dra...
PS2, Line 1593: The clock rate should be (data rate/2 - 4),
: * and the 4MHz is introduced to reduce interference from
: * RF peripherals like modem, WiFi, BlueTooth.
can you revise this to […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf5cce206e248bb327f9a7d27c4f364ef1c68aa1
Gerrit-Change-Number: 36990
Gerrit-PatchSet: 3
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-Comment-Date: Tue, 17 Dec 2019 08:22:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment