Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Paul Menzel, Sugnan Prabhu S, Tim Wawrzynczak. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61020 )
Change subject: src/driver/wifi: Add _DSM method for DDRRFIM ......................................................................
Patch Set 18:
(5 comments)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/61020/comment/58602f18_f91dfb56 PS18, Line 40: //bool is_cnviDdrRfim_enabled = false; delete this
https://review.coreboot.org/c/coreboot/+/61020/comment/1d0c0c5b_b31d2520 PS18, Line 160: bool *is_cnvi_ddr_rfim_enabled = false; This is creating a pointer that points to the value `false`, presumably 0... do you mean `bool *is_cnvi_ddr_rfim_enabled = NULL;` ?
https://review.coreboot.org/c/coreboot/+/61020/comment/4341cb63_87dfadb3 PS18, Line 542: bool *is_cnviDdrRfim_enabled = false; : *is_cnviDdrRfim_enabled = config->enable_cnvi_ddr_rfim; This would look cleaner if we just use a regular bool here, e.g. ``` bool is_cnvi_ddr_rfim_enabled;
is_cnvi_ddr_rfim_enabled = config->enable_cnvi_ddr_rfim; ```
https://review.coreboot.org/c/coreboot/+/61020/comment/950e368a_58ca4644 PS18, Line 606: if (*is_cnviDdrRfim_enabled) then `if (is_cnvi_ddr_rfim_enabled)`
https://review.coreboot.org/c/coreboot/+/61020/comment/d13715d4_9ebf71e2 PS18, Line 610: dsm_ids[dsm_count].arg = (void *)is_cnviDdrRfim_enabled; `dsm_ids[dsm_count].arg = &is_cnvi_ddr_rfim_enabled;`