Yuchen Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46395 )
Change subject: soc/mediatek/mt8192: add rtc MT6359P driver
......................................................................
Patch Set 48:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46395/47/src/soc/mediatek/mt8183/rt...
File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/c/coreboot/+/46395/47/src/soc/mediatek/mt8183/rt...
PS47, Line 253: low power detect function. */
code indent should use tabs where possible
fixed
https://review.coreboot.org/c/coreboot/+/46395/47/src/soc/mediatek/mt8192/rt...
File src/soc/mediatek/mt8192/rtc.c:
https://review.coreboot.org/c/coreboot/+/46395/47/src/soc/mediatek/mt8192/rt...
PS47, Line 271: low power detect function. */
code indent should use tabs where possible
fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57d6738fdec148c7458b2024a0a8225415ca2f3e
Gerrit-Change-Number: 46395
Gerrit-PatchSet: 48
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YuCheng Hung
yucheng_hung@asus.corp-partner.google.com
Gerrit-Reviewer: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 22 Dec 2020 12:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment