Hello Felix Singer, build bot (Jenkins), Nico Huber, Subrata Banik, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48360
to look at the new patch set (#3).
Change subject: mb/intel/coffeelake_rvp: Stop using headers for HDA verbs ......................................................................
mb/intel/coffeelake_rvp: Stop using headers for HDA verbs
One of the variants lacks an hda_verb.h, and hda_verb.c can't be built. Follow-up changes will make mainboard hda_verb.c files always get built through AZALIA_PLUGIN_SUPPORT, and breaks building this contraption.
Turn the headers into standalone compilation units to prevent this issue. Since they contain definitions, including them from multiple compilation units wasn't a good idea anyway.
Change-Id: I00d968563539a4e1b8d1e12145293439d8358555 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/coffeelake_rvp/Makefile.inc D src/mainboard/intel/coffeelake_rvp/hda_verb.c R src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c C src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c D src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h R src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c C src/mainboard/intel/coffeelake_rvp/variants/whl_u/hda_verb.c D src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h 8 files changed, 1 insertion(+), 893 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48360/3