1 Feb
2022
1 Feb
'22
6:58 p.m.
Attention is currently required from: Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61512 )
Change subject: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139687): https://review.coreboot.org/c/coreboot/+/61512/comment/0a1c968e_c5d27ecb PS2, Line 832: if (dw_i2c_gen_speed_config(dw_i2c_addr, speed, bcfg, &sgen) == CB_SUCCESS) { braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/61512
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55
Gerrit-Change-Number: 61512
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 01 Feb 2022 17:58:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment