Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31898 )
Change subject: tpm: Add API to query TPM presence
......................................................................
Patch Set 5:
Hi Patrick,
The new implementation for "tpm presence query" is broken. We use the TPM presence to differentiate between EVB and Proto boards(refer CB:32271)
The board_id in the libsysinfo stucture gets filled even before the TPM probe happens in the Ramstage. Hence, the dts for EVB boards is selected consistently in depthcharge because of the wrong board id.
Thanks,
Nitheesh Sekar
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa7b17085364bb631f43a133839773033721062d
Gerrit-Change-Number: 31898
Gerrit-PatchSet: 5
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Apr 2019 10:29:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment