Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46111 )
Change subject: trogdor: Modify DDR training to use mrc_cache ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46111/10/src/soc/qualcomm/common/qc... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/46111/10/src/soc/qualcomm/common/qc... PS10, Line 142: if we're being forced to retrain.
nit: this part doesn't really apply anymore.
Removed.
https://review.coreboot.org/c/coreboot/+/46111/10/src/soc/qualcomm/common/qc... PS10, Line 145: data_size = REGION_SIZE(ddr_training);
nit: this is kinda pointless here now
Removed data_size assignment.