hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver
......................................................................
Patch Set 27:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm...
File src/soc/mediatek/mt8192/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm...
PS14, Line 91: 50
We need the delay for stable clk, and it is described in ULPOSC_SW_Calibration.doc.
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm...
File src/soc/mediatek/mt8192/pmif_spi.c:
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm...
PS14, Line 321: 100
After checking, the project don't use modem feature, so we remove it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45398
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fc28f72d9522133baa06f9d67c383f814d862c
Gerrit-Change-Number: 45398
Gerrit-PatchSet: 27
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 13:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-MessageType: comment