Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: convert SGX and PRMRR devicetree options to Kconfig ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35799/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35799/7//COMMIT_MSG@9 PS7, Line 9: nod
not
Done
https://review.coreboot.org/c/coreboot/+/35799/7//COMMIT_MSG@19 PS7, Line 19: extendend
extended
Done
https://review.coreboot.org/c/coreboot/+/35799/5/src/soc/intel/common/block/... File src/soc/intel/common/block/sgx/sgx.c:
https://review.coreboot.org/c/coreboot/+/35799/5/src/soc/intel/common/block/... PS5, Line 39: static const struct sgx_param *get_sgx_param(void) : { : if (sgx_param_valid) : return &g_sgx_param; : : memset(&g_sgx_param, 0, sizeof(g_sgx_param)); : if (soc_fill_sgx_param(&g_sgx_param) < 0) { : printk(BIOS_ERR, "SGX : Failed to get soc sgx param\n"); : return NULL; : } : sgx_param_valid = true; : printk(BIOS_INFO, "SGX : param.enable = %d\n", g_sgx_param.enable); : : return &g_sgx_param; : } : : static int soc_sgx_enabled(void) : { : const struct sgx_param *sgx_param = get_sgx_param(); : return sgx_param ? sgx_param->enable : 0; : }
Done
https://review.coreboot.org/c/coreboot/+/35882
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... File src/soc/intel/common/block/sgx/sgx.c:
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... PS7, Line 57: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE) || !is_sgx_supported())
why? this would change the behaviour which I strictly want to avoid
just forget what I wrote...
https://review.coreboot.org/c/coreboot/+/35799/7/src/soc/intel/common/block/... PS7, Line 213: if (!CONFIG(SOC_INTEL_COMMON_BLOCK_SGX_ENABLE) || !is_sgx_supported()) {
same as above
Done