Attention is currently required from: Jamie Chen, Henry Sun, Tim Wawrzynczak, Paul Menzel, Ren Kuo, Angel Pons, Kane Chen, Patrick Rudolph.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60009 )
Change subject: soc/intel/jasperlake: Add CdClock frequency config
......................................................................
Patch Set 17:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60009/comment/145804c9_eccd2471
PS16, Line 7: CdClock
nit: `CdClock frequency`
Done
https://review.coreboot.org/c/coreboot/+/60009/comment/e9633dff_74b9278d
PS16, Line 9: This dev tree config controls the CdClock for Jasper Lake.
I'd reword and expand this a bit, stating what `CdClock` means and removing the redundant `for Jaspe […]
Done
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60009/comment/05a84d32_3c437d01
PS16, Line 208: # Core Display Clock Frequency selection
: register "CdClock" = "0xff"
With the changes I've suggested in my other comments, this is no longer needed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97
Gerrit-Change-Number: 60009
Gerrit-PatchSet: 17
Gerrit-Owner: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 23 Dec 2021 13:33:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment