[coreboot-gerrit] Change in coreboot[master]: hatch: Create stryke variant

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37229 )

Change subject: hatch: Create stryke variant
......................................................................

Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/stryke/gpio.c:

https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/... 
PS2, Line 21: static const struct pad_config gpio_table[] = {
I'm assuming these were taken from the Hatch variant, again no schematics to verify against.

https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/stryke/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/... 
PS2, Line 1: chip soc/intel/cannonlake
I don't see any schematics available to us, so I can't verify that any of this is accurate.

https://review.coreboot.org/c/coreboot/+/37229/2/src/mainboard/google/hatch/... 
PS2, Line 38: 			.rise_time_ns = 50,
            : 			.fall_time_ns = 15,
These will need to be tuned for your board.