Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54076 )
Change subject: mb/google/volteer/var/volteer2: Configure TCSS OC pins
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54076/comment/e69d590b_1dae2b6a
PS3, Line 9: volteer
The baseboard does, but I don't have schematics for all the variants to know which ones use the same […]
I think you should figure out how the pin needs to be configured for all variants. If it is the same as baseboard, just adding it in base devicetree makes sense. Else, you will have to update each individual overridetree.
Catherine/Tom/Zhuohao might be able to help determine this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12da755a1d3b9ec3ed0a2dbfb0782313dd49c7e9
Gerrit-Change-Number: 54076
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 12 May 2021 05:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment