Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45459 )
Change subject: lib/spd: respect spd memory part name override ......................................................................
Patch Set 62:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45459/58/src/include/spd_bin.h File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/45459/58/src/include/spd_bin.h@45 PS58, Line 45: const
This change was in response to a review comment, sounded like the right thing to do. […]
I would prefer keeping it in a separate CL.
https://review.coreboot.org/c/coreboot/+/45459/58/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/58/src/lib/spd_bin.c@147 PS58, Line 147: size_t *len)
Then we need to fix checkpatch : […]
Can you please submit an update to checkpatch to allow 96 characters: https://doc.coreboot.org/coding_style.html#breaking-long-lines-and-strings
https://review.coreboot.org/c/coreboot/+/45459/62/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/45459/62/src/lib/spd_bin.c@196 PS62, Line 196: %s Looks like use of len somehow got dropped here?