Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede...
PS5, Line 188: PAD_CFG_NF(GPP_D19, NONE, DEEP, NF2),
: /* D20 : WWAN_WLAN_COEX2 */
: PAD_CFG_NF(GPP_D20, NONE, DEEP, NF2),
: /* D21 : WWAN_WLAN_COEX3 */
: PAD_CFG_NF(GPP_D21, NONE, DEEP, NF1),
Aamir, Can you or someone from Intel help to address this comment?
Hi Karthik, I checked, these have to set to native in case we use integrated WLAN(Cnvi) + WWAN.
Also I see from EDS , only NF1 is defined for these pins, can you please check?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39115
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bb8e57cdb688bc544929c94af380b9ef1d936a2
Gerrit-Change-Number: 39115
Gerrit-PatchSet: 9
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 Mar 2020 15:23:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment