Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40391 )
Change subject: nb/intel/i440bx: Clean up register_values table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40391/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40391/1//COMMIT_MSG@11
PS1, Line 11: and probably will never be used. Drop it to save some bytes.
Please give hard numbers.
37 bytes off the table itself. I don't yet have an easy way to know how many bytes the coding changes save.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40391
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I020f616455bb671fe284993a488beb6386a03d0d
Gerrit-Change-Number: 40391
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 26 Apr 2020 22:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment