Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 45: default 0xb00000 if VBOOT
That's not a change but an addition, but I just realized we can drop "if VBOOT" because for vboot th […]
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 75: source "src/mainboard/supermicro/x11/variants/*/Kconfig"
This makes the Kconfig style way more readable by omitting "if" in every second line and moving vari […]
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 1: source "src/mainboard/supermicro/x11/variants/*/Kconfig.name"
Well, I could live with putting all board names here but I *strongly* vote for using the Kconfig sou […]
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 174:
Good idea, I'll change this
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 177:
Otherwise, misalignments happen like this one
Done