Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c...
PS7, Line 142: cbmem_size - wd_preram->buffer_offset,
Done
Well that's awkward. It turns out buffer_size is a uint16_t, which is too small to store VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE. The one place that it's actually used is in coreboot_table.c to give a size for the lb_range struct. Which probably isn't necessary to fill out, but could be nice for consistency. So maybe we should change it to uint32_t?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051be1e47bf79b15a1689d49a5d4c031e9363dfa
Gerrit-Change-Number: 36300
Gerrit-PatchSet: 9
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Nov 2019 17:35:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment