Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44905 )
Change subject: mb/google/puff: Convert ASL file to new DPTF dt impl ......................................................................
Patch Set 8:
(7 comments)
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 270: # Default DPTF Policy for all Puff boards if not overridden
Is this comment still accurate? […]
Let's remove it; it was more meaningful when it was in a baseboard devicetree.
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 274: 90 The first values should be 90, 85, 80, 75, 70, 65. The second values should be 95, 85, 75, 65, 55, 45 - or possibly 85, ..., 45, ?, since the 95s are actually used as the weight in the source ASL.
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 280: .thresholds={TEMP_PCT(50, 90), The second values should be 95, 85, ..., 45. This time, there's one fewer temperature in the source ASL so it doesn't fit in a different way.
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 288: CHARGER CPU
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 298: 3000 15000
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 304: 15000 25000
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 305: 60000 64000