Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................
Patch Set 2:
(1 comment)
I'll work this.
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbde...
File src/soc/amd/stoneyridge/enable_usbdebug.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/enable_usbde...
PS1, Line 32: return PCI_DEV(0, 0x16, 0);
: else if (hcd_idx == 2)
: return PCI_DEV(0, 0x13, 0);
I don't think these two exist on stoney.
You are correct, just checked with pci_list on my grunt.
--
To view, visit
https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Oct 2018 15:23:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No