Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41011 )
Change subject: soc/intel/common: Add ASL for TCSS PCI segment
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41011/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/extrahostbridge.asl:
https://review.coreboot.org/c/coreboot/+/41011/3/src/soc/intel/common/block/...
PS3, Line 16: Method (_CRS, 0, Serialized)
Can't we generate the AML at runtime?
https://review.coreboot.org/c/coreboot/+/41011/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/pcisegment.asl:
https://review.coreboot.org/c/coreboot/+/41011/3/src/soc/intel/common/block/...
PS3, Line 19: #define TBT_PCIe3_IRQ 19
These are SoC specific, no?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43924a3a34173ba3531079ef848f1935c59bb74a
Gerrit-Change-Number: 41011
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 May 2020 05:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment