Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36449 )
Change subject: mainboard/google: Allow Hatch variants to read SPD data over SMBus ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... PS2, Line 27: GPIO_MEM_CH_SEL
I don't think we need this for boards reading SPD via SMBus.
Done
https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... PS2, Line 48: memcfg.spd[0].read_type = READ_SMBUS;
yes, I think we should just use get_spd_smbus() and pass in the data into FSP. […]
Done
https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... PS2, Line 49: memcfg.spd[0].spd_spec.spd_smbus_address = (uintptr_t)blk.spd_array[0];
Your absolutely correct, I mixed this up with 'MemorySpdPtr00' too much CamelCase for my dyslexic br […]
Done
https://review.coreboot.org/c/coreboot/+/36449/2/src/mainboard/google/hatch/... PS2, Line 52: 1
Interesting, noted thanks. I will rework this implementation based on this and the above. […]
Done