Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/...
PS2, Line 146: VBOOT_EARLY_EC_SYNC
The issue is that early ec sync needs to be disabled for efs2 to function correctly, see commit 6daa […]
Thanks for the info.
The commit message for commit 6daa8c3ba5f says: "Early ec sync needs to be disabled for EFS2 to function." But it does not provide enough context to understand whether VEES should be enabled for all LAPTOPs or just for all !PUFF, nor whether this is a temporary workaround, or the final solution.
Can you please add a bit more detailed comment here and/or in the commit message to explain the linkage?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33
Gerrit-Change-Number: 40252
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrew McRae
amcrae@chromium.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 01:25:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment