Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35496 )
Change subject: sc7180: Add clock driver ......................................................................
Patch Set 20:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/cl... File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/cl... PS15, Line 82: write32(&((struct sc7180_clock_mnd *)clk)->m, m &
Please do something like […]
Done
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/cl... PS15, Line 183: &gcc->qup_wrap1_s[s];
nit: maybe fit both sides of the colon on one line now?
Done
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/cl... PS15, Line 185: clock_configure((struct sc7180_clock *)&qup_clk->clk, qup_cfg, hz,
Please pass &qup_clk->clk. […]
Done
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/in... PS15, Line 58: struct sc7180_clock_mnd clk;
nit: Maybe call this 'mnd' or 'mnd_clk' to be easier to tell it apart from the struct sc7180_clock i […]
Done
https://review.coreboot.org/c/coreboot/+/35496/15/src/soc/qualcomm/sc7180/in... PS15, Line 110: };
edit: Oh, I guess CB:35503 is already doing some of that
Done