Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support ......................................................................
Patch Set 2:
(1 comment)
I am not opposed to this change, however we need to be careful to not break Chromium ToT by removing the IGNORE_INIT_FAILURE flag. We should add the new flag and migrate to it before removing the old flag. Also have you verified that all keys work as expected in depthcharge including F12 and the arrow keys?
https://review.coreboot.org/c/coreboot/+/37594/2/payloads/libpayload/Kconfig File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/37594/2/payloads/libpayload/Kconfig... PS2, Line 346: PC_KEYBOARD_IGNORE_INIT_FAILURE We should keep this in place until we can remove uses of it from the Chromium codebase.