Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat...
File src/device/resource_allocator_v4.c:
https://review.coreboot.org/c/coreboot/+/41443/6/src/device/resource_allocat...
PS6, Line 272: mark_resource_invalid(resource);
First, I don't see how `base == limit` implies or disables anything. Please explain. […]
Okay. I think I understand what you are saying. Let's continue discussion on the PCI driver CLs you have pushed. I think it makes sense to use the semantics:
IORESOURCE_ASSIGNED: Resource is allocated space by the allocator. If allocation fails, IORESOURCE_ASSIGNED will not be set and all resource attributes(base, limit, size) will be left untouched.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide4d98528197bb03850a8fb4d73c41cd2c0195aa
Gerrit-Change-Number: 41443
Gerrit-PatchSet: 6
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 May 2020 04:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment