[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/gen1/smmrelocate: Check for sanity on SMRR

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30709 )

Change subject: cpu/intel/gen1/smmrelocate: Check for sanity on SMRR
......................................................................

Patch Set 5:

(1 comment)
> Patch Set 5:
>
> I'm kinda wondering if we can silently ignore that case, and what breaks then

It's a result from unaligned TSEG, which gets printed earlier. I can rework the code a little to clarify when or when not SMRR will be written to.

https://review.coreboot.org/#/c/30709/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30709/2//COMMIT_MSG@9 
PS2, Line 9: This happens when TSEG is found to be unaligned.
> Please add that also as a comment to the if statement. […]

A warning already gets printed.