build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h@... PS11, Line 114: #define DEFINE_BITFIELD(name, high_bit, low_bit) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/35463/11/src/include/device/mmio.h@... PS11, Line 114: #define DEFINE_BITFIELD(name, high_bit, low_bit) \ macros should not use a trailing semicolon