Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32327 )
Change subject: payload/seabios: Fix CBFS location on APL platform ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32327/3/payloads/external/SeaBIOS/Makefile File payloads/external/SeaBIOS/Makefile:
https://review.coreboot.org/#/c/32327/3/payloads/external/SeaBIOS/Makefile@4... PS3, Line 43: echo "CONFIG_CBFS_LOCATION=0xfffc0000" >> seabios/.config
I am not sure yet that we can just use this hard coded address and be fine on all the mainboards usi […]
src/soc/intel/apollolake/mmap_boot.c makes the same assumption. The fmap has to match the implementation used in coreboot.
We could however document what the fmap needs to look like, i.e. that the BIOS_UNUSABLE has to be 256KiB and has to be placed between CBFS and end of bios region.